This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(semantic_analyzers): fix the false positive for noConstAssign
#3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
ematipico
approved these changes
Nov 15, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
leops
reviewed
Nov 15, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Nov 16, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Nov 17, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
1 task
MichaReiser
reviewed
Nov 17, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Nov 18, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs
Outdated
Show resolved
Hide resolved
…_assign.rs Co-authored-by: Micha Reiser <micha@reiser.io>
MichaReiser
changed the title
noConstAssign
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for fixing #3728. The current implementation of noConstAssign did not skip function assignment that caused a false error for the lint rule.
Test Plan
I added two new test cases to cover this edge case.