fix(semantic_analyzers): fix the false positive for noConstAssign

crates/rome_js_analyze/src/semantic_analyzers/nursery/no_const_assign.rs

@@ -2,7 +2,7 @@ use crate::semantic_services::Semantic;
 use rome_analyze::context::RuleContext;
 use rome_analyze::{declare_rule, Rule, RuleDiagnostic};
 use rome_console::markup;
-use rome_js_syntax::{JsIdentifierAssignment, JsVariableDeclaration};
+use rome_js_syntax::{JsFormalParameter, JsIdentifierAssignment, JsVariableDeclaration};
 use rome_rowan::{AstNode, TextRange};
 
 declare_rule! {
@@ -61,13 +61,14 @@ impl Rule for NoConstAssign {
         let model = ctx.model();
 
         let declared_binding = model.declaration(node)?;
-        if let Some(variable_declaration) = declared_binding
-            .syntax()
-            .ancestors()
-            .find_map(|ancestor| JsVariableDeclaration::cast_ref(&ancestor))
-        {
-            if variable_declaration.is_const() {
-                return Some(declared_binding.syntax().text_trimmed_range());
+        for node in declared_binding.syntax().ancestors() {
+            if let Some(_) = JsFormalParameter::cast_ref(&node) {
+                return None;
+            }
+            if let Some(variable_declaration) = JsVariableDeclaration::cast_ref(&node) {
+                if variable_declaration.is_const() {
+                    return Some(declared_binding.syntax().text_trimmed_range());
+                }
             }
         }
 

crates/rome_js_analyze/tests/specs/nursery/noConstAssign.js

@@ -1,11 +1,18 @@
 const a = 1;
 a = 2;
 
-const b = 2, c = 43;
+const b = 2,
+	c = 43;
 b = 4;
 ++b;
 b += 45;
 b--;
 function f() {
-    b++;
-}
+	b++;
+}
+function f(d) {
+	b++;
+}
+const fn = (val) => {
+	val = 0;
+};

crates/rome_js_analyze/tests/specs/nursery/noConstAssign.js.snap

@@ -1,20 +1,29 @@
 ---
 source: crates/rome_js_analyze/tests/spec_tests.rs
+assertion_line: 99
 expression: noConstAssign.js
 ---
 # Input
 ```js
 const a = 1;
 a = 2;
 
-const b = 2, c = 43;
+const b = 2,
+	c = 43;
 b = 4;
 ++b;
 b += 45;
 b--;
 function f() {
-    b++;
+	b++;
 }
+function f(d) {
+	b++;
+}
+const fn = (val) => {
+	val = 0;
+};
+
 ```
 
 # Diagnostics
@@ -27,7 +36,7 @@ noConstAssign.js:2:1 lint/nursery/noConstAssign ━━━━━━━━━━
   > 2 │ a = 2;
       │ ^
     3 │ 
-    4 │ const b = 2, c = 43;
+    4 │ const b = 2,
 
   i This is where the variable is defined as constant
 
@@ -40,119 +49,145 @@ noConstAssign.js:2:1 lint/nursery/noConstAssign ━━━━━━━━━━
 ```
 
 ```
-noConstAssign.js:5:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+noConstAssign.js:6:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Can't assign b because it's a constant
 
-    4 │ const b = 2, c = 43;
-  > 5 │ b = 4;
+    4 │ const b = 2,
+    5 │ 	c = 43;
+  > 6 │ b = 4;
       │ ^
-    6 │ ++b;
-    7 │ b += 45;
+    7 │ ++b;
+    8 │ b += 45;
 
   i This is where the variable is defined as constant
 
     2 │ a = 2;
     3 │ 
-  > 4 │ const b = 2, c = 43;
+  > 4 │ const b = 2,
       │       ^
-    5 │ b = 4;
-    6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
 
 
 ```
 
 ```
-noConstAssign.js:6:3 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+noConstAssign.js:7:3 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Can't assign b because it's a constant
 
-    4 │ const b = 2, c = 43;
-    5 │ b = 4;
-  > 6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
+  > 7 │ ++b;
       │   ^
-    7 │ b += 45;
-    8 │ b--;
+    8 │ b += 45;
+    9 │ b--;
 
   i This is where the variable is defined as constant
 
     2 │ a = 2;
     3 │ 
-  > 4 │ const b = 2, c = 43;
+  > 4 │ const b = 2,
       │       ^
-    5 │ b = 4;
-    6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
 
 
 ```
 
 ```
-noConstAssign.js:7:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+noConstAssign.js:8:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Can't assign b because it's a constant
 
-    5 │ b = 4;
-    6 │ ++b;
-  > 7 │ b += 45;
-      │ ^
-    8 │ b--;
-    9 │ function f() {
+     6 │ b = 4;
+     7 │ ++b;
+   > 8 │ b += 45;
+       │ ^
+     9 │ b--;
+    10 │ function f() {
 
   i This is where the variable is defined as constant
 
     2 │ a = 2;
     3 │ 
-  > 4 │ const b = 2, c = 43;
+  > 4 │ const b = 2,
       │       ^
-    5 │ b = 4;
-    6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
 
 
 ```
 
 ```
-noConstAssign.js:8:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+noConstAssign.js:9:1 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Can't assign b because it's a constant
 
-     6 │ ++b;
-     7 │ b += 45;
-   > 8 │ b--;
+     7 │ ++b;
+     8 │ b += 45;
+   > 9 │ b--;
        │ ^
-     9 │ function f() {
-    10 │     b++;
+    10 │ function f() {
+    11 │ 	b++;
+
+  i This is where the variable is defined as constant
+
+    2 │ a = 2;
+    3 │ 
+  > 4 │ const b = 2,
+      │       ^
+    5 │ 	c = 43;
+    6 │ b = 4;
+
+
+```
+
+```
+noConstAssign.js:11:2 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Can't assign b because it's a constant
+
+     9 │ b--;
+    10 │ function f() {
+  > 11 │ 	b++;
+       │ 	^
+    12 │ }
+    13 │ function f(d) {
 
   i This is where the variable is defined as constant
 
     2 │ a = 2;
     3 │ 
-  > 4 │ const b = 2, c = 43;
+  > 4 │ const b = 2,
       │       ^
-    5 │ b = 4;
-    6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
 
 
 ```
 
 ```
-noConstAssign.js:10:5 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+noConstAssign.js:14:2 lint/nursery/noConstAssign ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Can't assign b because it's a constant
 
-     8 │ b--;
-     9 │ function f() {
-  > 10 │     b++;
-       │     ^
-    11 │ }
+    12 │ }
+    13 │ function f(d) {
+  > 14 │ 	b++;
+       │ 	^
+    15 │ }
+    16 │ const fn = (val) => {
 
   i This is where the variable is defined as constant
 
     2 │ a = 2;
     3 │ 
-  > 4 │ const b = 2, c = 43;
+  > 4 │ const b = 2,
       │       ^
-    5 │ b = 4;
-    6 │ ++b;
+    5 │ 	c = 43;
+    6 │ b = 4;
 
 
 ```