This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): noPrecisionLoss
correctly handle 1 digit ints
#4087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4086.
The bug is due to a divergence between the Rust std formatting of floats and the rule's formatting.
Indeed,
1
is formatted to5e0
by Rust'sformat!
, while1
is formatted to5.e0
by the rule.The fix aligns the rule's format to the Rsut format.
Test Plan
New unit test included.
Documentation