Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac ARM64 #6120

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Mac ARM64 #6120

merged 5 commits into from
Aug 5, 2020

Conversation

Axel-Naumann
Copy link
Member

Get ROOT to work on Apple Mac ARM.

Notably missing is tbb, which should get fixed by uxlfoundation/oneTBB#258

AArch64 needs a different alignment for atomics, such as the first
member of TROOT. It cannot see that it needs that alignement for
the buffer storing TROOT, because it's just an array of char-s.

Use a union to force the proper alignment.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

Copy link
Contributor

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From CMake point everything looks ready, but I was wondering which combination of CMake flags you tried? -Dall=on?

@Axel-Naumann
Copy link
Member Author

-Dall=on no - there are only few externals ported to ARM Mac so far. I think tbb will be a key next step (I had to disable it). So far it works with asimage builtin_afterimage builtin_clang builtin_freetype builtin_ftgl builtin_gl2ps builtin_glew builtin_llvm builtin_lz4 builtin_lzma builtin_openssl builtin_pcre builtin_vdt builtin_xrootd builtin_xxhash builtin_zstd clad cocoa dataframe exceptions gdml http libcxx mlp opengl pyroot roofit runtime_cxxmodules shared sqlite ssl tmva spectrum vdt xml xrootd which isn't too bad.

@oshadura oshadura self-requested a review August 5, 2020 09:05
Copy link
Contributor

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Axel-Naumann Axel-Naumann merged commit 3fee72d into root-project:master Aug 5, 2020
@Axel-Naumann Axel-Naumann deleted the macarm64 branch August 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants