Add detection of arm64 architecture for macos builds #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds detection of arm64 for macos builds on arm64 hardware. The only change necessary is an additional case in the code where macos.inc queries and detects the system architecture.
5 tasks
|
Confirming that the |
1 task
chrisburr
added a commit
to regro-cf-autotick-bot/tbb-feedstock
that referenced
this pull request
Dec 7, 2020
Axel-Naumann
added a commit
to Axel-Naumann/root
that referenced
this pull request
Jan 12, 2021
Axel-Naumann
added a commit
to Axel-Naumann/root
that referenced
this pull request
Jan 12, 2021
Axel-Naumann
added a commit
to root-project/root
that referenced
this pull request
Jan 13, 2021
* [cmake] Patch tbb for Apple M1 (issue #6903). Apply patch from uxlfoundation/oneTBB#258
|
@betajippity oneTBB has moved to CMake. please update the patch (if still applicable) |
|
@betajippity , FIY oneTBB should work on ARM64 (at least on Windows), for more details see #507 |
|
It seems that this is already implemented in oneTBB 2021.3 See #344 for more details. @betajippity please reopen if something is missing |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds detection of arm64 for macos builds on arm64 hardware.
The only change necessary is an additional case in the code where
macos.inc queries and detects the system architecture.