0.0.2 rev and workflow integration #15
Conversation
- Packaging is based on litr markdown: tests.R has all tests - Will edit test file names after all tests are added
- functions are reorganized in a fewer R files - workflow yaml extension fix - Added one test, fixed errors in previous tests
- While keeping litr Rmd, others were adjusted - codecov edit to find if it works
- added stars in "Imports"
|
Still figuring out YAML file settings for running the test. |
|
@sigmafelix I don't think we need the codecov.yaml - the test-coverage calls covr and should apply the codecov.io test coverage report. |
- linebreak to whitespace
- tictoc in one of examples was removed; system.time() is in place
- poly_weight will contain numeric/integer fields only
- path argument in codecov does not accept dot as the current directory
- Deprecated functions were removed - Example with implicit dependency is removed - covr.io upload part was commented out from YAML
- Provisional. Subject to change. - Last test-coverage passed, R CMD check failed
|
R CMD check keeps failing. I will revisit the error codes and try to run R CMD check locally before push any changes. |
|
@sigmafelix The R CMD Check has 5 warnings which causes it to fail. It has lots of suggestions, but it is not always straight forward to debug. One thing that may alleviate a lot of this is proper folder naming. R CMD check will expect all of the R scipts to be in R with no other subfolders. As it is in scromps/R/ that be a source of many issues. One drastic option is to start from scratch with R package building (e.g. use_this) and let it build things as it expects from the ground up. |
|
@sigmafelix I see what you mean now. You have scomps set up as an R package within our repo name. Should I rename the repo to scomps and then you can make the necessary folder changes to move scomps to be the package and repo root? |
- Added functions - Fixed missing argument entries in Roxygen documentation - Roxygen syntax error fixed - Vignette naming convention - Local R CMD check passed with three NOTEs, no WARNINGs/ERRORs
|
The author of this PR, sigmafelix, is not an activated member of this organization on Codecov. |
|
@Spatiotemporal-Exposures-and-Toxicology I think the repo name was properly reflected in *.yaml files for GitHub Actions. The push just I made returned no warnings when |
|
@Spatiotemporal-Exposures-and-Toxicology Finally the recent push passed the test. I will keep the directory layout of this repo as-is for the time being. I think I will do |
|
@sigmafelix codecov.io is working, but I think the nested package is causing an issue with giving line-by-line coverage. Let me know if you can see the line coverage at codecov.io. See similar issue here: |
|
@Spatiotemporal-Exposures-and-Toxicology I think that is because I disabled covr::codecov run in the yaml file. I will close this one and reopen a PR with the full yaml file. |
No description provided.