Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to control.ros.org #1083

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

christophfroehlich
Copy link
Contributor

This fixes some links pointing to broken ros-controls.github.io URLs.

@codecov-commenter
Copy link

Codecov Report

Merging #1083 (2a97230) into master (925f5f3) will decrease coverage by 2.21%.
The diff coverage is 34.83%.

❗ Current head 2a97230 differs from pull request most recent head 4b21f3a. Consider uploading reports for the commit 4b21f3a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
- Coverage   34.61%   32.41%   -2.21%     
==========================================
  Files          52       94      +42     
  Lines        2981     9937    +6956     
  Branches     1855     6694    +4839     
==========================================
+ Hits         1032     3221    +2189     
- Misses        310      789     +479     
- Partials     1639     5927    +4288     
Flag Coverage Δ
unittests 32.41% <34.83%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 37.94% <ø> (-1.77%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 46.76% <ø> (-6.87%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 20 files with indirect coverage changes

@bmagyar bmagyar merged commit 6dec7e9 into ros-controls:master Jul 24, 2023
16 of 17 checks passed
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jul 24, 2023
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
(cherry picked from commit 6dec7e9)

# Conflicts:
#	.github/ISSUE_TEMPLATE/good-first-issue.md
@christophfroehlich christophfroehlich deleted the fix_link branch January 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants