Update test_resource_manager.cpp - Fixed Typo

[Parker-Drouillard]

Fixed typo causing errors during build, test case was written as initilizable and not initializable as was expected by the tests.

[Parker-Drouillard]

Apologies, I also missed correcting the typo on line 118 of the same file, and on line 258 in ros2_control/install/ros2_control_test_assets/include/ros2_control_test_assets/descriptions.hpp at line 458.

Not quite used to using the web editor for pull requests. I am uncertain the appropriate way to handle this?

[christophfroehlich]

Fixed typo causing errors during build, test case was written as initilizable and not initializable as was expected by the tests.

You are right about a typo, but it is still not correct: it should be uninitializable 😀, if that's even an English word (according to deepl it is).
What errors did you get by compiling the master? The scoped trace macro has an arbitrary string, and the test name is not used elsewhere?

Not quite used to using the web editor for pull requests. I am uncertain the appropriate way to handle this?

You can checkout the PR locally, or just open the patch-1 branch of your fork in the github UI, edit file, and commit directly to the branch.

[Parker-Drouillard]

Fixed typo causing errors during build, test case was written as initilizable and not initializable as was expected by the tests.

You are right about a typo, but it is still not correct: it should be uninitializable 😀, if that's even an English word (according to deepl it is). What errors did you get by compiling the master? The scoped trace macro has an arbitrary string, and the test name is not used elsewhere?

Not quite used to using the web editor for pull requests. I am uncertain the appropriate way to handle this?

You can checkout the PR locally, or just open the patch-1 branch of your fork in the github UI, edit file, and commit directly to the branch.

While using colcon build, I got a blocking error stating the following, among other unrelated errors (I replaced my local path with ~~)

~~/src/ros2_control/controller_manager/test/test_controller_manager_urdf_passing.cpp: In member function ‘virtual void TestControllerManagerWithTestableCM_expect_to_failure_when_invalid_urdf_is_given_and_be_able_to_submit_new_robot_description_Test::TestBody()’:
~~/src/ros2_control/controller_manager/test/test_controller_manager_urdf_passing.cpp:86:40: error: ‘minimal_uninitializable_robot_urdf’ is not a member of ‘ros2_control_test_assets’; did you mean ‘minimal_unitilizable_robot_urdf’?
   86 |   msg.data = ros2_control_test_assets::minimal_uninitializable_robot_urdf;
      |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                        minimal_unitilizable_robot_urdf

[Parker-Drouillard]

also I am laughing at the fact I didn't catch the fact that it's in and not un. Good catch on your part

[bmagyar]

The changes look legit but we fixed those typos months ago and had many releases since. I'm wondering how a few creeped back into the codebase especially w the CI being happy

[christophfroehlich]

I'm wondering the same, maybe @Parker-Drouillard has a very old release installed as binary, and colcon uses now the test assets from the old release instead of the new one from the src folder?

[Parker-Drouillard]

I'm wondering the same, maybe @Parker-Drouillard has a very old release installed as binary, and colcon uses now the test assets from the old release instead of the new one from the src folder?

I doubt that, I only started with ROS a week ago, and the hardware I'm on was a fresh install as of two days ago.

I have seen the typo in both the master and humble branches. This is my first ever open source contribution though so it's possible I'm doing something wrong!

[Parker-Drouillard]

From what I remember earlier, the changes had been pushed back in something like 5 days ago by someone.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (465b58f) to head (98f807b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1609   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files         108      108           
  Lines        9866     9866           
  Branches      890      890           
=======================================
  Hits         8614     8614           
  Misses        929      929           
  Partials      323      323           

Flag	Coverage Δ
unittests	87.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...e_interface_testing/test/test_resource_manager.cpp	99.32% <100.00%> (ø)

[christophfroehlich]

The typo fix of the current commit is fine, but should not change anything regarding your build failure. And our CI on the master as well as humble branch is happy..

[saikishor]

I'm wondering the same, maybe @Parker-Drouillard has a very old release installed as binary, and colcon uses now the test assets from the old release instead of the new one from the src folder?

I believe yes. I faced the same as your said @christophfroehlich

[Parker-Drouillard]

I'm wondering the same, maybe @Parker-Drouillard has a very old release installed as binary, and colcon uses now the test assets from the old release instead of the new one from the src folder?

I believe yes. I faced the same as your said @christophfroehlich

Is this possible considering I'm on a fresh install of Ubuntu 22.04 as of a few days ago? I also only started getting into ros2 about a week ago, am I somehow pulling old binaries?

[christophfroehlich]

Yes, because since a couple of months there is no rolling release to 22.04 any more -> there was a switch to noble 24.04. I'm not sure what we can do to avoid such a confusion. @saikishor a compile-time error if the wrong version of hardware_interface_testing is to be built?

[saikishor]

Yes, because since a couple of months there is no rolling release to 22.04 any more -> there was a switch to noble 24.04. I'm not sure what we can do to avoid such a confusion. @saikishor a compile-time error if the wrong version of hardware_interface_testing is to be built?

I've tried using jammy and compiling it from source and it works. I have been working on Jammy for last 2 months

[saikishor]

LGTM