-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICI: Remove caching of workspace #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as all checks are green!
Wait - if we remove the target_ws cache we do not increase build time? Then I really think this is worth going that route. |
Please verify that once again 😄 but the two workflow runs I've linked above don't show any difference. |
6e7b7e4
to
b049b1c
Compare
Also for semi-binary builds, the build-step of ICI takes approx 30s only with/without cache (the upstream workspace was not cached anyways). |
Fixes #33 the easiest way: just don't cache the workspace, but only ccache directory.
This also resolved some weird include errors while updating an upstream dependency in ros-controls/ros2_control#1485 (yes, we could delete the caches manually but still..)