Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICI: Remove caching of workspace #49

Merged
merged 4 commits into from
Apr 16, 2024
Merged

ICI: Remove caching of workspace #49

merged 4 commits into from
Apr 16, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 16, 2024

Fixes #33 the easiest way: just don't cache the workspace, but only ccache directory.

Does it make sense to cache the workspace at all, how much is the speed benefit compared to only caching ccache?

  • Locally, it takes 20s vs 2min if I remove the build folder.
  • cache vs no cache of ros2_control binary build: The ICI step takes the same time.

This also resolved some weird include errors while updating an upstream dependency in ros-controls/ros2_control#1485 (yes, we could delete the caches manually but still..)

@christophfroehlich christophfroehlich changed the title Try fixing caches ICI: Remove caching of workspace Apr 16, 2024
@christophfroehlich christophfroehlich marked this pull request as ready for review April 16, 2024 17:36
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all checks are green!

@fmauch
Copy link
Contributor

fmauch commented Apr 16, 2024

Wait - if we remove the target_ws cache we do not increase build time? Then I really think this is worth going that route.

@christophfroehlich
Copy link
Contributor Author

Wait - if we remove the target_ws cache we do not increase build time? Then I really think this is worth going that route.

Please verify that once again 😄 but the two workflow runs I've linked above don't show any difference.

@christophfroehlich
Copy link
Contributor Author

Also for semi-binary builds, the build-step of ICI takes approx 30s only with/without cache (the upstream workspace was not cached anyways).

@christophfroehlich christophfroehlich merged commit 8cb6085 into master Apr 16, 2024
2 checks passed
@christophfroehlich christophfroehlich deleted the fix_caches branch April 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICI workflow: Cache is shared between different jobs
3 participants