Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use reusable wfs from ros2_control_ci and use matrix strategy #1040

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9f7e9e9) 47.71% compared to head (dd4a65e) 71.72%.
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1040       +/-   ##
===========================================
+ Coverage   47.71%   71.72%   +24.00%     
===========================================
  Files          41       41               
  Lines        3871     3639      -232     
  Branches     1833     1782       -51     
===========================================
+ Hits         1847     2610      +763     
+ Misses        751      715       -36     
+ Partials     1273      314      -959     
Flag Coverage Δ
unittests 71.72% <73.13%> (+24.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 68.63% <100.00%> (+20.57%) ⬆️
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (+20.00%) ⬆️
...include/joint_trajectory_controller/trajectory.hpp 73.33% <ø> (+23.33%) ⬆️
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
...roadcaster/src/force_torque_sensor_broadcaster.cpp 82.53% <75.00%> (+21.93%) ⬆️
...ory_controller/src/joint_trajectory_controller.cpp 80.45% <87.50%> (+33.33%) ⬆️
joint_trajectory_controller/src/trajectory.cpp 89.67% <77.77%> (+22.10%) ⬆️
tricycle_controller/src/tricycle_controller.cpp 60.58% <60.60%> (+27.93%) ⬆️

... and 28 files with indirect coverage changes

@bmagyar bmagyar merged commit cb6884a into ros-controls:master Feb 15, 2024
14 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
(cherry picked from commit cb6884a)

# Conflicts:
#	.github/workflows/humble-binary-build.yml
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-semi-binary-build.yml
#	.github/workflows/humble-semi-binary-build.yml
#	.github/workflows/humble-source-build.yml
#	.github/workflows/iron-binary-build-testing.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-semi-binary-build.yml
#	.github/workflows/iron-semi-binary-build-testing.yml
#	.github/workflows/reusable-industrial-ci-with-cache.yml
#	.github/workflows/rolling-binary-build-testing.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-semi-binary-build.yml
#	.github/workflows/rolling-semi-binary-build-testing.yml
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
(cherry picked from commit cb6884a)

# Conflicts:
#	.github/workflows/humble-binary-build-testing.yml
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-semi-binary-build.yml
#	.github/workflows/humble-semi-binary-build-main.yml
#	.github/workflows/iron-binary-build.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-semi-binary-build.yml
#	.github/workflows/iron-semi-binary-build.yml
#	.github/workflows/iron-source-build.yml
#	.github/workflows/reusable-industrial-ci-with-cache.yml
#	.github/workflows/reusable-ros-tooling-source-build.yml
#	.github/workflows/rolling-binary-build-testing.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-semi-binary-build.yml
#	.github/workflows/rolling-semi-binary-build-testing.yml
@christophfroehlich christophfroehlich deleted the ci_reusable_wfs branch February 15, 2024 11:35
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants