Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conditioning to have rolling tags compilable in older versions #1071

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

saikishor
Copy link
Member

This PR complements the ros2_control PR: ros-controls/ros2_control#1422.

For this, the version conditionings is added to avoid compilation error:

We would need the upstream version of control_msgs as well to compile the rolling branch in old versions

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (61617b3) to head (60d908e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
- Coverage   71.56%   71.56%   -0.01%     
==========================================
  Files          41       41              
  Lines        3651     3650       -1     
  Branches     1794     1792       -2     
==========================================
- Hits         2613     2612       -1     
  Misses        712      712              
  Partials      326      326              
Flag Coverage Δ
unittests 71.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...troller/include/diff_drive_controller/odometry.hpp 20.00% <ø> (ø)
..._state_broadcaster/src/joint_state_broadcaster.cpp 81.64% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 79.52% <ø> (ø)
pid_controller/src/pid_controller.cpp 68.57% <ø> (ø)
...ensor_broadcaster/src/range_sensor_broadcaster.cpp 79.62% <ø> (-0.38%) ⬇️
...steering_controllers_library/steering_odometry.hpp 100.00% <ø> (ø)
...ring_controllers_library/src/steering_odometry.cpp 69.03% <100.00%> (ø)
...ontroller/include/tricycle_controller/odometry.hpp 100.00% <ø> (ø)

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM and compiled on humble.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!!

@bmagyar bmagyar merged commit 0b43291 into ros-controls:master Mar 4, 2024
13 checks passed
@christophfroehlich christophfroehlich deleted the rolling_compilable_in_humble branch March 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants