[JTC] Deprecate start_with_holding
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
deprecate_start_with_holding
branch
from
d5b3ee5
to
c696df0
Compare
github-actions
bot
requested review from
aprotyas,
bmagyar,
DasRoteSkelett,
destogl,
erickisos,
jaron-l and
livanov93
|
@Mergifyio backport humble |
✅ Backports have been created
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## iron #1076 +/- ##
==========================================
- Coverage 71.61% 71.59% -0.03%
==========================================
Files 40 40
Lines 3449 3450 +1
Branches 1695 1698 +3
==========================================
Hits 2470 2470
- Misses 676 682 +6
+ Partials 303 298 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aprotyas
approved these changes
Mar 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit ea66755) # Conflicts: # joint_trajectory_controller/src/joint_trajectory_controller.cpp # joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided not to remove
start_with_holdingin iron/humble, see #839 and #876.So let's deprecate it.