Fix admittance controller interface read/write logic (backport #1232) #1234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ROS
rolling
and gazeboHarmonic
, I've found two bugs while trying to control a robot using bothvelocity
andposition
control.write_state_to_hardware()
,state_commanded.positions
are mistakenly being written to bothvelocity
andacceleration
command interfaces.write_state_to_hardware()
andread_state_from_hardware()
, checking whether the controller haspos
/vel
/acc
interfaces is done usingif-else
clauses. This causes the block to exit upon first true condition, meaning, after confirmingposition
interface exists,velocity
andacceleration
interfaces never get written to or read fromThese fixes are verified in my use case, but seem obvious enough that no tests need to be written to verify these claims.
Nonetheless, let me know if you'd like some tests before merging.
Cheers!
This is an automatic backport of pull request #1232 done by [Mergify](https://mergify.com).