Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeout): do not reset steer wheels to 0. on timeout #1289

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

reinzor
Copy link
Contributor

@reinzor reinzor commented Sep 13, 2024

Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.

Instead of setting the incoming twist command velocity to zero, we should
only set the wheel commands to zero without altering the steering angles
in order to avoid in-place steering of the wheels.
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thanks for the contribution.
Could you please have a look on the failing tests and change the assertions accordingly?
Please add also a short description in the release_notes.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (57c50e5) to head (c8794cf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...llers_library/src/steering_controllers_library.cpp 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   80.34%   80.31%   -0.04%     
==========================================
  Files         105      105              
  Lines        9393     9358      -35     
  Branches      831      826       -5     
==========================================
- Hits         7547     7516      -31     
+ Misses       1570     1567       -3     
+ Partials      276      275       -1     
Flag Coverage Δ
unittests 80.31% <71.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...library/test/test_steering_controllers_library.cpp 100.00% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 79.54% <71.42%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. Just two minor comments

reinzor and others added 2 commits September 27, 2024 11:14
…brary.cpp

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…brary.cpp

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@bmagyar bmagyar merged commit 1004054 into ros-controls:master Oct 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants