-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(timeout): do not reset steer wheels to 0. on timeout #1289
Conversation
00d9b3f
to
8a9658e
Compare
Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.
8a9658e
to
d706812
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, thanks for the contribution.
Could you please have a look on the failing tests and change the assertions accordingly?
Please add also a short description in the release_notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
14b57a5
to
dcbf13a
Compare
Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
dcbf13a
to
ca0cefc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 80.34% 80.31% -0.04%
==========================================
Files 105 105
Lines 9393 9358 -35
Branches 831 826 -5
==========================================
- Hits 7547 7516 -31
+ Misses 1570 1567 -3
+ Partials 276 275 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up. Just two minor comments
steering_controllers_library/test/test_steering_controllers_library.cpp
Outdated
Show resolved
Hide resolved
steering_controllers_library/test/test_steering_controllers_library.cpp
Outdated
Show resolved
Hide resolved
…brary.cpp Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…brary.cpp Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.