Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSB] Fix the behaviour of publishing unavailable state interfaces when they are previously available (backport #1331) #1339

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 1, 2024

Hello!

While reviewing the Example 13, I came across this situation described in the comment : ros-controls/ros2_control_demos#417 (comment)

After debugging, the resource manager properly sets the state interfaces. However, some internal variables are not properly reset, and this results in the publishing of previously available interfaces.

The proposed fix fixes the issue of properly publishing the state of the known state interfaces alone


This is an automatic backport of pull request #1331 done by Mergify.

…en they are previously available (#1331)

* Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment)

* Add fix to solve the issue of the publishing non-existing joint_states

(cherry picked from commit 87f21b3)
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 39 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (115ef91) to head (0cdd100).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
..._broadcaster/test/test_joint_state_broadcaster.cpp 35.00% 0 Missing and 39 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1339      +/-   ##
==========================================
- Coverage   65.25%   65.20%   -0.05%     
==========================================
  Files         107      107              
  Lines       12219    12282      +63     
  Branches     7536     7589      +53     
==========================================
+ Hits         7973     8009      +36     
+ Misses       1561     1555       -6     
- Partials     2685     2718      +33     
Flag Coverage Δ
unittests 65.20% <38.09%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._state_broadcaster/src/joint_state_broadcaster.cpp 83.04% <100.00%> (+2.08%) ⬆️
..._broadcaster/test/test_joint_state_broadcaster.cpp 49.81% <35.00%> (+0.02%) ⬆️

@christophfroehlich christophfroehlich merged commit b941ab0 into humble Nov 1, 2024
8 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1331 branch November 1, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants