-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency to gpio_controllers #1410
Conversation
@Mergifyio backport mergify/bp/humble/pr-1251 |
✅ Backports have been created
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 122 122
Lines 10994 10994
Branches 937 937
=======================================
Hits 9188 9188
Misses 1492 1492
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit dc60f6f)
* Gpio command controller (#1251) --------- Co-authored-by: m.bednarczyk <m.bednarczyk@unistra.fr> Co-authored-by: Maciej Bednarczyk <macbednarczyk@gmail.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit 0590c6a) # Conflicts: # doc/release_notes.rst * Update release_notes.rst * Fix GPIO controller on humble (#1403) * Add compatibility build for humble+jazzy distro (#1368) (#1373) (cherry picked from commit 3b600f2) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> * Fix compilation and align UTs * Update docs --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> * Remove range-loop-construct compile options * Add missing dependency to gpio_controllers (#1410) (#1412) (cherry picked from commit dc60f6f) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> --------- Co-authored-by: Wiktor Bajor <69388767+Wiktor-99@users.noreply.github.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Some tests were failing in the backport #1372 due to a missing test dependency.
I also updated the maintainers in the package.xml
@Mergifyio backport mergify/bp/humble/pr-1251