Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency to gpio_controllers #1410

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

Some tests were failing in the backport #1372 due to a missing test dependency.

I also updated the maintainers in the package.xml

@Mergifyio backport mergify/bp/humble/pr-1251

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport mergify/bp/humble/pr-1251

Copy link
Contributor

mergify bot commented Dec 5, 2024

backport mergify/bp/humble/pr-1251

✅ Backports have been created

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (cd73055) to head (d2d43ea).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         122      122           
  Lines       10994    10994           
  Branches      937      937           
=======================================
  Hits         9188     9188           
  Misses       1492     1492           
  Partials      314      314           
Flag Coverage Δ
unittests 83.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit dc60f6f into master Dec 6, 2024
18 of 20 checks passed
@christophfroehlich christophfroehlich deleted the fix/gpio branch December 6, 2024 09:38
mergify bot pushed a commit that referenced this pull request Dec 6, 2024
christophfroehlich added a commit that referenced this pull request Dec 6, 2024
(cherry picked from commit dc60f6f)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Dec 6, 2024
* Gpio command controller (#1251)

---------

Co-authored-by: m.bednarczyk <m.bednarczyk@unistra.fr>
Co-authored-by: Maciej Bednarczyk <macbednarczyk@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
(cherry picked from commit 0590c6a)

# Conflicts:
#	doc/release_notes.rst

* Update release_notes.rst

* Fix GPIO controller on humble (#1403)

* Add compatibility build for humble+jazzy distro (#1368) (#1373)

(cherry picked from commit 3b600f2)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

* Fix compilation and align UTs

* Update docs

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

* Remove range-loop-construct compile options

* Add missing dependency to gpio_controllers (#1410) (#1412)

(cherry picked from commit dc60f6f)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

---------

Co-authored-by: Wiktor Bajor <69388767+Wiktor-99@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants