-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DiffDriveController] Optional tf namespace prefixes instead of using node namespace (backport #533) #726
Conversation
@bmagyar Any chance this could get merged in? |
Not with the current conflict in place... Wanna fix it via comments? I can commit those (from the phone, at roscon) and see if the CI is happy. |
We can try! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests come from JTC tests having hiccups
… node namespace (#533) * [DiffDiveController] Changed the namespace appending from '/' to '_' with optional tf_frame_prefix parameter. If not set it will not append anything. * [DiffDriveController] Add option to enable/disable TF prefix. On by default. If prefix not set and is enabled then namespace is used by default. (cherry picked from commit 5c0327d) # Conflicts: # diff_drive_controller/src/diff_drive_controller.cpp
Co-authored-by: Ben Holden <94607409+bobbleballs@users.noreply.github.com>
fc1092b
to
b84fe03
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## humble #726 +/- ##
==========================================
- Coverage 45.21% 44.84% -0.38%
==========================================
Files 40 40
Lines 3709 3713 +4
Branches 1765 1769 +4
==========================================
- Hits 1677 1665 -12
- Misses 821 835 +14
- Partials 1211 1213 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This is an automatic backport of pull request #533 done by Mergify.
Cherry-pick of 5c0327d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com