Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DiffDriveController] Optional tf namespace prefixes instead of using node namespace (backport #533) #726

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[DiffDriveController] Optional tf namespace prefixes instead of using node namespace (backport #533) #726

merged 4 commits into from
Dec 6, 2023

Commits on Dec 6, 2023

  1. [DiffDriveController] Optional tf namespace prefixes instead of using… 

    … node namespace (#533)

* [DiffDiveController] Changed the namespace appending from '/' to '_' with optional tf_frame_prefix parameter. If not set it will not append anything.
* [DiffDriveController] Add option to enable/disable TF prefix. On by default. If prefix not set and is enabled then namespace is used by default.

(cherry picked from commit 5c0327d)

# Conflicts:
#	diff_drive_controller/src/diff_drive_controller.cpp
    @bobbleballs @christophfroehlich
    bobbleballs authored and christophfroehlich committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    091aceb View commit details
    Browse the repository at this point in the history

  2. Feature off by default

    @bmagyar @christophfroehlich
    bmagyar authored and christophfroehlich committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6b114b5 View commit details
    Browse the repository at this point in the history

  3. undo the wrong fix

    @bmagyar @christophfroehlich
    bmagyar authored and christophfroehlich committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    5a33687 View commit details
    Browse the repository at this point in the history

  4. Fix merge conflicts 

    Co-authored-by: Ben Holden <94607409+bobbleballs@users.noreply.github.com>
    @christophfroehlich @bobbleballs
    christophfroehlich and bobbleballs committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b84fe03 View commit details
    Browse the repository at this point in the history