Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what rosdep install does #670

Merged
merged 1 commit into from
May 6, 2019
Merged

Clarify what rosdep install does #670

merged 1 commit into from
May 6, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 19, 2019

This changes the help text of the rosdep install command.

I have not run rosdep with this change locally. I'm assuming it is safe because it is only changing a line in a multi-line string.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. It seems that yaml.load due to unsafe behavior is now hard failing in python3. re: #651 and the unchanged instances.

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #670 into master will increase coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   75.19%   76.06%   +0.87%     
==========================================
  Files          30       30              
  Lines        2890     2987      +97     
==========================================
+ Hits         2173     2272      +99     
+ Misses        717      715       -2
Impacted Files Coverage Δ
src/rosdep2/main.py 48.49% <ø> (ø) ⬆️
src/rosdep2/platforms/debian.py 89.14% <0%> (+3.42%) ⬆️
src/rosdep2/platforms/redhat.py 92.59% <0%> (+5.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe63aaa...1a1693f. Read the comment docs.

@tfoote tfoote merged commit 307b641 into master May 6, 2019
@tfoote tfoote deleted the rosdep_install_docs branch May 6, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants