map-size restriction to avoid overflow and nullptr caused by user-mis…

…configuration (#3242)

* odom alpha restriction

* odom alpha code style

* odom alpha code style

* odom alpha code style

* map-size restriction

* map-size code style

* map-size rejection

* map-size codestyle

* map-size return false

nav2_costmap_2d/src/costmap_2d_ros.cpp

@@ -637,11 +637,27 @@ Costmap2DROS::dynamicParametersCallback(std::vector<rclcpp::Parameter> parameter
       }
     } else if (type == ParameterType::PARAMETER_INTEGER) {
       if (name == "width") {
-        resize_map = true;
-        map_width_meters_ = parameter.as_int();
+        if (parameter.as_int() > 0) {
+          resize_map = true;
+          map_width_meters_ = parameter.as_int();
+        } else {
+          RCLCPP_ERROR(
+            get_logger(), "You try to set width of map to be negative or zero,"
+            " this isn't allowed, please give a positive value.");
+          result.successful = false;
+          return result;
+        }
       } else if (name == "height") {
-        resize_map = true;
-        map_height_meters_ = parameter.as_int();
+        if (parameter.as_int() > 0) {
+          resize_map = true;
+          map_height_meters_ = parameter.as_int();
+        } else {
+          RCLCPP_ERROR(
+            get_logger(), "You try to set height of map to be negative or zero,"
+            " this isn't allowed, please give a positive value.");
+          result.successful = false;
+          return result;
+        }
       }
     } else if (type == ParameterType::PARAMETER_STRING) {
       if (name == "footprint") {