Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch RVIZ using launch_ros::Actions::Node #1286

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Launch RVIZ using launch_ros::Actions::Node #1286

merged 2 commits into from
Oct 28, 2019

Conversation

orduno
Copy link
Contributor

@orduno orduno commented Oct 23, 2019

Basic Info

Info Please fill out this column
Ticket(s) this addresses #1272
Primary OS tested on Ubuntu 18.04
Robotic platform tested on Gazebo simulation of TB3

Description of contribution in a few bullet points

Updating simulation launch files to launch RVIZ as a node instead of using ExecuteProcess.

mkhansenbot
mkhansenbot approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@orduno orduno mentioned this pull request Oct 25, 2019
Closed
@orduno orduno self-assigned this Oct 28, 2019
@orduno orduno merged commit cd239d6 into ros-navigation:master Oct 28, 2019
@orduno orduno deleted the issues/1272_launch_rviz branch October 28, 2019 18:00
savalena pushed a commit to savalena/navigation2 that referenced this pull request Jul 5, 2024
@orduno
Launch RVIZ using launch_ros::Actions::Node (ros-navigation#1286)
45f7301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@mkhansenbot mkhansenbot mkhansenbot approved these changes

Assignees

@orduno orduno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orduno @mkhansenbot @SteveMacenski