Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foxy] More Windows build fix. #1959

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[Foxy] More Windows build fix. #1959

merged 1 commit into from
Aug 19, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Aug 19, 2020

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Windows
Robotic platform tested on Turtlebot3 Simulation

Description of contribution in a few bullet points

  • Those build breaks are found by building against release-foxy-20200807.
  • tf_help has a linkage dependency on conversions for the usage of poseStampedToPose2D.
  • Fixed a time\duration conversion build break in ros_topic_logger.cpp.
  • Added the missing dependency angles for nav2_costmap_2d.

Description of documentation updates required from your changes

N/A

Future work that may be required in bullet points

N/A

@SteveMacenski SteveMacenski merged commit db2f917 into ros-navigation:foxy-devel Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanyen @SteveMacenski