Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize variables in inflation layer #1970

Merged
merged 1 commit into from
Aug 31, 2020
Merged

initialize variables in inflation layer #1970

merged 1 commit into from
Aug 31, 2020

Conversation

mikeferguson
Copy link
Contributor

another fix from noetic release

ros-planning/navigation@71b95c2

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #1970 into main will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
- Coverage   79.28%   78.91%   -0.38%     
==========================================
  Files         219      219              
  Lines       10588    10588              
==========================================
- Hits         8395     8355      -40     
- Misses       2193     2233      +40     
Flag Coverage Δ
#project 78.91% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nav2_costmap_2d/plugins/inflation_layer.cpp 98.80% <ø> (ø)
...av2_dwb_controller/dwb_critics/src/oscillation.cpp 68.67% <0.00%> (-19.28%) ⬇️
nav2_navfn_planner/src/navfn_planner.cpp 87.27% <0.00%> (-6.07%) ⬇️
nav2_recoveries/plugins/spin.cpp 88.00% <0.00%> (-5.34%) ⬇️
...v2_util/include/nav2_util/simple_action_server.hpp 89.37% <0.00%> (-2.50%) ⬇️
...lifecycle_manager/src/lifecycle_manager_client.cpp 87.80% <0.00%> (-2.44%) ⬇️
...av2_costmap_2d/src/footprint_collision_checker.cpp 88.37% <0.00%> (-2.33%) ⬇️
nav2_navfn_planner/src/navfn.cpp 90.86% <0.00%> (-0.49%) ⬇️
nav2_amcl/src/amcl_node.cpp 84.54% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e994f...0f99724. Read the comment docs.

@SteveMacenski SteveMacenski merged commit 0a2dfbe into main Aug 31, 2020
@SteveMacenski SteveMacenski deleted the uninitialized branch August 31, 2020 17:39
SteveMacenski added a commit that referenced this pull request Nov 4, 2020
* initialize variables in inflation layer (#1970)

* Fix zero waypoints crash (#1978)

* return if the number of waypoints is zero.

* terminate the action.

* Succeed action instead of terminating.

* Add IsBatteryLow condition node (#1974)

* Add IsBatteryLow condition node

* Update default battery topic and switch to battery %

* Fix test

* Switch to sensor_msgs/BatteryState

* Add option to use voltage by default or switch to percentage

* Add sensor_msgs dependency in package.xml

* Make percentage default over voltage

* Update parameter list

* Initialize inflate_cone_ variable. (#1988)

* Initialize inflate_cone_ variable.

* initialize inflate_cone_ based on parameter.

* Increase the sleep time in the tests makes the costmap test always succeed on my machine.

* Add timeouts to all spin_until_future_complete calls (#1998)

* Add timeouts to all spin_until_future_complete calls

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Update default timeout value

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Controllers should not be influenced by time jumps or slew (#2012)

* Controllers should not be influenced by time jumps

Therefore use rclcpp::GenericRate<std::chrono::steady_clock> instead of
rclcpp::Rate

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Change to using `rclcpp::WallRate` for better readability

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Fix max path cycles for case where map has larger Y dimension than X dimension (#2017)

* Fix max path cycles for case where map has larger Y dimension than X dimension

* Improve readability

* fix ament_cpplint and ament_uncrustify issues

* fix minor cherry pick conflict mistake

* bump version to 0.4.4

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
Co-authored-by: Wilco Bonestroo <w.j.bonestroo@saxion.nl>
Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
Co-authored-by: Martijn Buijs <Martijn.buijs@gmail.com>
Co-authored-by: justinIRBT <69175069+justinIRBT@users.noreply.github.com>
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants