Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve SimpleActionServer #2459

Merged
merged 3 commits into from
Jul 26, 2021
Merged

improve SimpleActionServer #2459

merged 3 commits into from
Jul 26, 2021

Commits on Jul 23, 2021

  1. improve SimpleActionServer 

    Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>

add a bool argument spin_thread whether use callback group/executor combo with dedicated thread to handle server

Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
    @gezp
    gezp committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    c171a5e View commit details
    Browse the repository at this point in the history

  2. use Nodethread for executor 

    Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
    @gezp
    gezp committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    36c6c8b View commit details
    Browse the repository at this point in the history

  3. add constructor's arg options and member variable executor_ 

    Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
    @gezp
    gezp committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    df7a4ac View commit details
    Browse the repository at this point in the history