Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all shared_ptr references to shared_ptr #2976

Merged
merged 2 commits into from
May 31, 2022

Conversation

naiveHobo
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #2966
Primary OS tested on Ubuntu 20.04
Robotic platform tested on Gazebo simulation of turtlebot3

Description of contribution in a few bullet points

  • Changed all const shared_ptr & references to shared_ptrs so counter increment takes place properly

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented May 27, 2022

@naiveHobo, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs https://navigation.ros.org/migration/Galactic.html Migration guide for API change (towards the top)

@SteveMacenski
Copy link
Member

Diff with 8 lines
--- src/simple_smoother.cpp
+++ src/simple_smoother.cpp.uncrustify
@@ -27 +27 @@
-  std::string name, std::shared_ptr<tf2_ros::Buffer> /*tf*/,
+  std::string name, std::shared_ptr<tf2_ros::Buffer>/*tf*/,
@@ -29 +29 @@
-  std::shared_ptr<nav2_costmap_2d::FootprintSubscriber> /*footprint_sub*/)
+  std::shared_ptr<nav2_costmap_2d::FootprintSubscriber>/*footprint_sub*/)

@SteveMacenski
Copy link
Member

I made the change, just waiting on another run of CI

@SteveMacenski SteveMacenski merged commit 4d596b9 into ros-navigation:main May 31, 2022
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jun 30, 2022
* Change all shared_ptr references to shared_ptr

* Update simple_smoother.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
doisyg pushed a commit to wyca-robotics/teb_local_planner that referenced this pull request Jul 5, 2022
SteveMacenski pushed a commit to rst-tu-dortmund/teb_local_planner that referenced this pull request Sep 12, 2022
* new lib g2o

* FootprintModel in Tebconfig and make it dynamic (no type change allowed)

* change dyn param method

* dynamically get robot_base_frame from costmap

* use only one global_frame variable (from cfg)

* remove map_frame param since it is set from costmap

* tf2_geometry_msgs.h depreciation

* nav2 PR 2976

ros-navigation/navigation2#2976

* fix compiler warnings

* fix costmap_converter plugin load

* Merge from ros2-master

* unneeded register_type function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants