remove LifecycleNode's argument use_rclcpp_node #2993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhenpeng ge zhenpeng.ge@qq.com
Basic Info
Description of contribution in a few bullet points
this is a final PR to solve #816
use_rclcpp_node
and memberrclcpp_node_
which is unused currently.test_costmap_topic_collision_checker.cpp
which userclcpp_node_
(like Reduce costmap_2d_ros nodes #2489).Description of documentation updates required from your changes
update migration documentation : ros-navigation/docs.nav2.org#321
Future work that may be required in bullet points
For Maintainers: