Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Modified findVelocitySignChange method to transform cusp into robot… (backport #3036) #3041

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 24, 2022

  1. - Modified findVelocitySignChange method to transform cusp into robot… (

    #3036)
    
    * - Modified findVelocitySignChange method to transform cusp into robot frame before returning distance_to_cusp
    
    * - Previous commit had incorrect usage of method transformPose based on different nav2 branch.
    - Now a placeholder pose, input pose and desired frame id is passed.
    
    * - Previous commit had incorrect usage of method transformPose based on different nav2 branch.
    - Now a placeholder pose, input pose and desired frame id is passed.
    
    Signed-off-by: Steven Brills <sbrills@hotmail.com>
    
    * Failed lint check due to stray blank line.  Removed the blank line
    
    * - Modified findVelocitySignChange function to take the transformed plan in robot's frame
    - Removed need to pass pose to the findVelocitySignChange function
    
    * - Modified the test file to reflect change in new parameters that findVelocitySignChange expects.
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    * - Corrected call to transformGlobalPoseWrapper method of BasicAPIRPP object.
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    * - transformGlobalPlanWrapper call bug fix
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    * - Updated tests now require frame_id and time_stamp for conversion since transformed plan is to be used.
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    * - Missing ; in test method
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead
    
    * -Modified findVelocitySignChange tests in test_regulated_pp to use transformed_plan instead
    
    Signed-off-by: Steven Brills <stevenbrills@hotmail.com>
    
    Co-authored-by: Steven Brills <sbrills@aethon.com>
    (cherry picked from commit 99bec08)
    stevenbrills authored and mergify[bot] committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    b787779 View commit details
    Browse the repository at this point in the history