Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support result codes for path planner in benchmarking #3323

Conversation

AlexeyMerzlyakov
Copy link
Collaborator

Support new result codes of Path Planner in Nav2 benchmarking suite, added since 1c10617


Basic Info

Info Please fill out this column
Ticket(s) this addresses #3043
Primary OS tested on Ubuntu 20.04
Robotic platform tested on TB3 simulation

Description of contribution in a few bullet points

  • Added the support of non-NULL return states from computePlan() (passed as action_server->terminate_current(result) with non-empty argument).
  • Fixed the bug in planning_benchmark_bringup.py when the Map Server can not start with non-existing map.

Description of documentation updates required from your changes

Not required


For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2022

@AlexeyMerzlyakov, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit a5c690f into ros-navigation:main Dec 13, 2022
andrewlycas pushed a commit to StratomInc/navigation2 that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants