Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address code cov loss due to unclean shutdown (issue #3271) #3377

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Address code cov loss due to unclean shutdown (issue #3271) #3377

merged 5 commits into from
Feb 1, 2023

Commits on Feb 1, 2023

  1. Ensure that we break bonds in lifecycle node/manager prior to rcl_shu… 

    …tdown.

Partial fix for Issue ros-navigation#3271

Signed-off-by: mbryan <matthew.bryan@dell.com>
    mbryan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e6cf45a View commit details
    Browse the repository at this point in the history

  2. Add unit tests for lifecycle_node rcl shutdown cb. 

    For Issue ros-navigation#3271.

Signed-off-by: mbryan <matthew.bryan@dell.com>
    mbryan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    624a5e7 View commit details
    Browse the repository at this point in the history

  3. Ensure planner_server shuts down cleanly on SIGINT. 

    Needed to ensure code coverage flushes. See Issue ros-navigation#3271.

Signed-off-by: mbryan <matthew.bryan@dell.com>
    mbryan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1b3959c View commit details
    Browse the repository at this point in the history

  4. Ensure costmap_2d_cloud does not seg fault on SIGINT. 

    One of several clean shutdown issues being address via Issue ros-navigation#3271.

Signed-off-by: mbryan <matthew.bryan@dell.com>
    mbryan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    57a791e View commit details
    Browse the repository at this point in the history

  5. Fix flake8 issues in some test files 

    Signed-off-by: mbryan <matthew.bryan@dell.com>
    mbryan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4f5ab95 View commit details
    Browse the repository at this point in the history