Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Codespaces prebuilds #3470

Merged
merged 11 commits into from
Mar 13, 2023
Merged

Use Codespaces prebuilds #3470

merged 11 commits into from
Mar 13, 2023

Commits on Mar 11, 2023

  1. Add commands to devcontainer

    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    397b50b View commit details
    Browse the repository at this point in the history

  2. Set builtin bash to be safe 

    https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425
https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    13835ea View commit details
    Browse the repository at this point in the history

  3. Setup workspace on create

    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    beaddfd View commit details
    Browse the repository at this point in the history

  4. Revert use of set -u for bash 

    don't raise error due to variables
otherwise colcon setup.sh chokes from using an unbounded path variable
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    d8f6673 View commit details
    Browse the repository at this point in the history

  5. Add safe.directory for git config 

    otherwise colcon cache errors out because of issues with git
due to complex user mapping magic that vscode does with devcontainers

https://stackoverflow.com/questions/72978485/git-submodule-update-failed-with-fatal-detected-dubious-ownership-in-repositor

also used by Moveit2:
moveit/moveit2#1994

https://github.blog/2022-04-12-git-security-vulnerability-announced/
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    73b9014 View commit details
    Browse the repository at this point in the history

  6. Set env using remoteEnv 

    instead of inlining them in scripts
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    81e1709 View commit details
    Browse the repository at this point in the history

  7. Revert to using the main tag 

    now that the tester stage has been replicated
with the new devcontainer script commands instead
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    df25cb6 View commit details
    Browse the repository at this point in the history

  8. formating

    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    847bc02 View commit details
    Browse the repository at this point in the history

  9. Scrap -dev image tag 

    and use codspaces prebuilds instead
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    7913a22 View commit details
    Browse the repository at this point in the history

  10. Build incrementally from update content command 

    by copying the build workspace steps from circleci config
    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    2c2f0ba View commit details
    Browse the repository at this point in the history

  11. Adapt the build workspace steps for bash

    @ruffsl
    ruffsl committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    9b88230 View commit details
    Browse the repository at this point in the history