Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nav2_planner] Fix costmap thread reset on cleanup #3548

Merged
merged 3 commits into from
May 2, 2023
Merged

[nav2_planner] Fix costmap thread reset on cleanup #3548

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d00a3b6
remove costmap thread reset on cleanup
BriceRenaudeau Apr 28, 2023
87cb174
Init costmap thread in on_configure method
BriceRenaudeau May 2, 2023
229ed78
Move costmap_thread init in on_configure method
BriceRenaudeau May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nav2_planner/src/planner_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ PlannerServer::on_cleanup(const rclcpp_lifecycle::State & /*state*/)
}

planners_.clear();
costmap_thread_.reset();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a better move to move the node thread creation into the configure function. Deleting the memory in the cleanup stage is the purpose of the stage so this is technically correct. I don't see any reason (do you?) why we couldn't create the thread in configure instead? That seems like it should work just as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tested it, and It works the same way.

costmap_ = nullptr;
return nav2_util::CallbackReturn::SUCCESS;
}
Expand Down