Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron Sync 3 - Sept 25 #3837

Merged
merged 22 commits into from
Sep 25, 2023
Merged

Iron Sync 3 - Sept 25 #3837

merged 22 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Same orientation of coordinate frames in rviz ang gazebo (#3751)

    * rviz view straight in default xy orientation
    
    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    
    * gazebo orientation to match rviz
    
    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    
    * rotating in direction of view
    
    ---------
    
    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    ct2034 authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9483a0a View commit details
    Browse the repository at this point in the history
  2. Fix flaky costmap filters tests: (#3754)

    1. Set forward_prune_distance to 1.0 to robot not getting lost
    2. Correct map name for costmap filter tests
    AlexeyMerzlyakov authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    31e3928 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50d00a3 View commit details
    Browse the repository at this point in the history
  4. Fix missing mutex in PlannerServer::isPathValid (#3756)

    Signed-off-by: ymd-stella <world.applepie@gmail.com>
    ymd-stella authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    845c30f View commit details
    Browse the repository at this point in the history
  5. Rename PushRosNamespace to PushROSNamespace (#3763)

    Tony Najjar authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c58b59f View commit details
    Browse the repository at this point in the history
  6. Rewrite the scan topic costmap plugins for multi-robot(namespace) bef…

    …ore launch navigation. (#3572)
    
    * Make it possible to launch namspaced robot which rewrites `<robot_namespace>` to namespace.
    - It allows to apply namespace automatically on specific target topic path in costmap plugins.
    
    Add new nav2 params file for multi-robot(rewriting `<robot_namespace>`) as an example.
    - nav2_multirobot_params_all.yaml
    
    Modify nav2_common.ReplaceString
    - add condition argument
    
    * Update nav2_bringup/launch/bringup_launch.py
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    
    * Add new luanch script for multi-robot bringup
    
    Rename luanch script for multi-robot simulation bringup
    
    Add new nav2_common script
    - Parse argument
    - Parse multirobot pose
    
    Update README.md
    
    * Update README.md
    
    Apply suggestions from code review
    
    Fix pep257 erors
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    
    ---------
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    hyunseok-yang and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    16b7f26 View commit details
    Browse the repository at this point in the history
  7. use ros clock for wait (#3782)

    * use ROS clock for wait
    
    * fix backport issue
    
    ---------
    
    Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
    2 people authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f19807a View commit details
    Browse the repository at this point in the history
  8. fixing external users of the BT action node template (#3792)

    * fixing external users of the BT action node template
    
    * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
    
    Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
    SteveMacenski and doisyg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c305fad View commit details
    Browse the repository at this point in the history
  9. Fixing typo in compute path through poses error codes (#3799)

    Signed-off-by: Mannucci, Anna (Bosch (CR)) <Anna.Mannucci@de.bosch.com>
    Co-authored-by: Mannucci, Anna (Bosch (CR)) <Anna.Mannucci@de.bosch.com>
    2 people authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c2bcf12 View commit details
    Browse the repository at this point in the history
  10. Fixes for flaky WPF test (#3785)

    * Fixes for flaky WPF test:
    * New RewrittenYaml ability to add non-existing parameters
    * Prune distance fix for WPF test
    * Treat UNKNOWN status as error in WPF
    * Clear error codes after BT run
    * Remove unnecessary setInitialPose() from WPF test
    
    * Update nav2_waypoint_follower/src/waypoint_follower.cpp
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    
    * Clean error code in any situation
    
    * Fix UNKNOWN WPF status handling
    
    ---------
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    AlexeyMerzlyakov and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0cc6567 View commit details
    Browse the repository at this point in the history
  11. Fix min_points comparison check (#3795)

    * Fix min_points checking
    tonynajjar authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bcbb1d6 View commit details
    Browse the repository at this point in the history
  12. Expose action server result timeout as a parameter in bt navigator se…

    …rvers (#3787)
    
    * Expose action server default timeout in bt navigator servers
    
    * typo
    
    * duplicated comment
    
    * Expose result timeout in other actions
    
    * Proper timeout in bt node
    
    * Change default timeouts and remove comments
    
    * Remove comment in params file
    
    * uncrustify controller server
    pepisg authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a85466b View commit details
    Browse the repository at this point in the history
  13. Using Simple Commander API for multi robot systems (#3803)

    * support multirobot namespaces
    
    * add docs
    SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8fe6363 View commit details
    Browse the repository at this point in the history
  14. adding copy all params primitive for BT navigator (to ingest into rcl…

    …cpp) (#3804)
    
    * adding copy all params primitive
    
    * fix linting
    
    * lint
    
    * I swear to god, this better be the last linting issue
    
    * allowing params to be declared from yaml
    
    * Update bt_navigator.cpp
    SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5d743a2 View commit details
    Browse the repository at this point in the history
  15. Fix CD configuration link reference (#3811)

    * Fix CD configuration page reference
    
    * Add CM work on 6th ROS Developers Day reference
    AlexeyMerzlyakov authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a35b443 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    537ca45 View commit details
    Browse the repository at this point in the history
  17. fix broken behaviortree doc link (#3822)

    Signed-off-by: Anton Kesy <antonkesy@gmail.com>
    antonkesy authored and SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    731c719 View commit details
    Browse the repository at this point in the history
  18. [MPPI] complete minor optimaization with floating point calculations (#…

    …3827)
    
    * floating point calculations
    
    * Update optimizer_unit_tests.cpp
    
    * Update critics_tests.cpp
    
    * Update critics_tests.cpp
    SteveMacenski committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0f2c083 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    cffc138 View commit details
    Browse the repository at this point in the history
  20. Add nav2_gps_waypoint_follower (#2814)

    * Add nav2_gps_waypoint_follower
    
    * use correct client node while calling it to spin
    
    * changed after 1'st review
    
    * apply requested changes
    
    * nav2_util::ServiceClient instead of CallbackGroup
    
    * another  iteration to adress issues
    
    * update poses with function in the follower logic
    
    * add deps of robot_localization: diagnostics
    
    * fix typo in underlay.repo
    
    * add deps of robot_localization: geographic_info
    
    * minor clean-ups
    
    * bond_core version has been updated
    
    * rotation should also be considered in GPS WPFing
    
    * use better namings related to gps wpf orientation
    
    * handle cpplint errors
    
    * tf_listener needs to be initialized
    
    * apply requested changes
    
    * apply requested changes 3.0/3.0
    
    * fix misplaced ";"
    
    * use run time param for gps transform timeout
    
    * change timeout var name
    
    * make use of stop_on_failure for GPS too
    
    * passing emptywaypont vectors are seen as failure
    
    * update warning for empty requests
    
    * consider utm -> map yaw offset
    
    * fix missed RCLCPP info
    
    * reorrect action;s name
    
    * waypoint stamps need to be updated
    
    * Fix segmentation fault on waypoint follower
    
    * Parametric frames and matrix multiplications
    
    * Replace oriented navsatfix for geographic_msgs/geopose
    
    * Remove deprecated oriented  navsatfix message
    
    * Update branch name on robot_localization dependency
    
    * Fix parametric frames logic
    
    * Rename functions and adress comments
    
    * fix style in underlay.repos
    
    * remove duplicate word in underlay.repos
    
    * update dependency version of ompl
    
    * Template ServiceClient class to accept lifecycle node
    
    * Remove link to stackoverflow answer
    
    * Remove yaw offset compensation
    
    * Fix API change
    
    * Fix styling
    
    * Minor docs fixes
    
    * Fix style divergences
    
    * Style fixes
    
    * Style fixes v2
    
    * Style fixes v3
    
    * Remove unused variables and timestam overrides
    
    * restore goal timestamp override
    
    * WIP: Add follow gps waypoints test
    
    * Style fixes and gazebo world inertia fix
    
    * Reduce velocity smoother timeout
    
    * empty commit to rerun tests
    
    * Increment circle ci cache idx
    
    * Remove extra space in cmakelists.txt
    
    * Fix wrong usage of the global action server
    
    * update follow gps waypoints action definition
    
    * Fix action definition and looping
    
    * update params for the unit testing
    
    * WIP: update tests
    
    * fix tests
    
    * fixes to nav2 simple commander
    
    * add robot_localization localizer
    
    * Bring back from LL client
    
    * Update nav2_simple_commander/nav2_simple_commander/robot_navigator.py
    
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    
    * missing argument in test function
    
    * small test error
    
    * style fixes nav2 simple commander
    
    * rename cartesian action server
    
    ---------
    
    Co-authored-by: jediofgever <fetulahatas1@gmail.com>
    Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
    3 people committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d72b851 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    26a3d50 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    cd86381 View commit details
    Browse the repository at this point in the history