Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision monitor: Add polygon source #4275

Merged
merged 42 commits into from
Apr 29, 2024
Merged

Collision monitor: Add polygon source #4275

merged 42 commits into from
Apr 29, 2024

Conversation

SteveMacenski
Copy link
Member

Continuation of #3885

Copy link
Contributor

mergify bot commented Apr 24, 2024

This pull request is in conflict. Could you fix it @SteveMacenski?

Copy link
Contributor

mergify bot commented Apr 24, 2024

@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Copy link
Contributor

mergify bot commented Apr 25, 2024

@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski SteveMacenski marked this pull request as ready for review April 26, 2024 00:00
@SteveMacenski SteveMacenski changed the title Cm polygon source Collision monitor: Add polygon source Apr 26, 2024
@SteveMacenski SteveMacenski merged commit c93080c into main Apr 29, 2024
9 of 11 checks passed
@SteveMacenski SteveMacenski deleted the cm_polygon_source branch April 29, 2024 19:55
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* Add polygon source

* Revert "Merge branch 'add-collision-points-debug' into add-polygon-source"

This reverts commit 15c261c, reversing
changes made to 5a63584.

* .

* fix

* fix

* fix lint

* PR comments fixes

* fixes

* add test

* fix space

* use standard msg Polygonstamped

* draft

* .

* fixes

* fixes

* fixes

* fix

* revert

* fixes

* add detector test

* rebasing fixes

* Adding polygon source

* adjusting tests

* linting

---------

Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* Add polygon source

* Revert "Merge branch 'add-collision-points-debug' into add-polygon-source"

This reverts commit 15c261c, reversing
changes made to 5a63584.

* .

* fix

* fix

* fix lint

* PR comments fixes

* fixes

* add test

* fix space

* use standard msg Polygonstamped

* draft

* .

* fixes

* fixes

* fixes

* fix

* revert

* fixes

* add detector test

* rebasing fixes

* Adding polygon source

* adjusting tests

* linting

---------

Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* Add polygon source

* Revert "Merge branch 'add-collision-points-debug' into add-polygon-source"

This reverts commit 15c261c, reversing
changes made to 5a63584.

* .

* fix

* fix

* fix lint

* PR comments fixes

* fixes

* add test

* fix space

* use standard msg Polygonstamped

* draft

* .

* fixes

* fixes

* fixes

* fix

* revert

* fixes

* add detector test

* rebasing fixes

* Adding polygon source

* adjusting tests

* linting

---------

Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants