Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation of #4284 #4295

Merged
merged 3 commits into from
May 6, 2024
Merged

Continuation of #4284 #4295

merged 3 commits into from
May 6, 2024

Conversation

SteveMacenski
Copy link
Member

See #4284

Guillaume Doisy and others added 3 commits April 28, 2024 21:14
64 bit for index
9c4e65b 
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
@SteveMacenski
Graph storing in uint64
958d7dc
@SteveMacenski
Remove incorrect usage
a6f1f9e
@SteveMacenski
Copy link
Member Author

@doisyg also see a6f1f9e these are the lines I disagree with, they're changing conversions for handling of the costmap, not the Graph that was exceeding it. The costmap APIs will downshift these into unsigned int anyway per its API

@SteveMacenski SteveMacenski marked this pull request as ready for review May 3, 2024 17:43
@doisyg
Copy link
Contributor

doisyg commented May 6, 2024

Thanks for following up, makes sense!
(and checked with my big map)

@SteveMacenski SteveMacenski merged commit b6693c6 into main May 6, 2024
8 of 9 checks passed
@SteveMacenski SteveMacenski deleted the BR5 branch May 6, 2024 22:52
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
@SteveMacenski @enricosutera
Continuation of ros-navigation#4284 (ros-navigation#4295)
ac4d9c0 
* 64 bit for index

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* Graph storing in uint64

* Remove incorrect usage

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
@SteveMacenski @Marc-Morcos
Continuation of ros-navigation#4284 (ros-navigation#4295)
45165fd 
* 64 bit for index

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* Graph storing in uint64

* Remove incorrect usage

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
@SteveMacenski @Manos-G
Continuation of ros-navigation#4284 (ros-navigation#4295)
71c8204 
* 64 bit for index

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* Graph storing in uint64

* Remove incorrect usage

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 22, 2024
@SteveMacenski
Continuation of ros-navigation#4284 (ros-navigation#4295)
1492fe6 
* 64 bit for index

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* Graph storing in uint64

* Remove incorrect usage

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveMacenski @doisyg