Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes the issue when the path longer on approach decorator goes to idle state #4300

Merged
merged 1 commit into from
May 6, 2024
Merged

fixes the issue when the path longer on approach decorator goes to idle state #4300

merged 1 commit into from
May 6, 2024

Conversation

padhupradheep
Copy link
Member

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4110
Primary OS tested on (Ubuntu
Robotic platform tested on Neobotix ROX
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Crux of the issue seems that the status of the node is set to IDLE. Last year, when I had implemented, the status ended up to success and went IDLE only when the entire BT was IDLE. This IDLE state was blocking the logic of the intended decorator going forward. I however have found a fix, that uses the goals of the old path and the new path, to avoid the blocking.

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@padhupradheep
fixes the issue when the decorator goes to idle state
36cd984 
Signed-off-by: PRP <padhupradheep@gmail.com>
@SteveMacenski
Copy link
Member

Thanks!!

@SteveMacenski SteveMacenski merged commit d0a65d5 into ros-navigation:main May 6, 2024
8 of 9 checks passed
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
@padhupradheep @enricosutera
fixes the issue when the decorator goes to idle state (ros-navigation…
c3a19d8 
…#4300)

Signed-off-by: PRP <padhupradheep@gmail.com>
Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
@padhupradheep @Marc-Morcos
fixes the issue when the decorator goes to idle state (ros-navigation…
da3e4cf 
…#4300)

Signed-off-by: PRP <padhupradheep@gmail.com>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
@padhupradheep @Manos-G
fixes the issue when the decorator goes to idle state (ros-navigation…
50bc7a1 
…#4300)

Signed-off-by: PRP <padhupradheep@gmail.com>
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 22, 2024
@padhupradheep
fixes the issue when the decorator goes to idle state (ros-navigation…
808f91d 
…#4300)

Signed-off-by: PRP <padhupradheep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padhupradheep @SteveMacenski