-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp CMake to make compilation significantly faster #4357
Closed
clalancette
wants to merge
22
commits into
ros-navigation:iron
from
clalancette:clalancette/cmake-revamp
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dfa7ce5
Revamp nav2_util CMakeLists.txt to use modern idioms.
clalancette 02efe70
Update nav2_behavior_tree to use modern CMake idioms.
clalancette 9716133
Switch nav2_voxel_grid to modern CMake idioms.
clalancette 55d26a9
Switch nav2_map_server to modern CMake idioms.
clalancette 096928b
Switch nav2_amcl to modern CMake idioms.
clalancette 3679802
Convert nav2_costmap_2d to modern CMake idioms.
clalancette 58d9e36
Small updates to nav2_core.
clalancette e55df65
Update nav2_behaviors to use modern CMake idioms.
clalancette a98e0b3
Switch nav2_bt_navigator to modern CMake idioms.
clalancette 92301f2
Swithc nav2_collision_monitor to modern CMake idioms.
clalancette 8044841
Revamp nav2_constrained_smoother to use modern CMake idioms.
clalancette 63d3b6f
Switch nav_2d_utils to use modern CMake idioms.
clalancette 9d3e628
Switch nav2_controller to modern CMake idioms.
clalancette 9e3ed8d
Switch nav2_lifecycle_manager to modern CMake idioms.
clalancette 2f5fdfe
Switch nav2_mppi_controller to use modern CMake idioms.
clalancette eda8ba3
Switch nav2_navfn_planner to modern CMake idioms.
clalancette 3b87d7c
Switch nav2_planner to modern CMake idioms.
clalancette 7e66b91
Switch nav2_regulated_pure_pursuit_controller to modern CMake idioms.
clalancette 55477b5
Switch nav2_rotation_shim_controller to modern CMake idioms.
clalancette a30efd0
Switch nav2_rviz_plugins to modern CMake idioms.
clalancette 2038f2b
Rewrite nav2_system_tests to use modern CMake idioms.
clalancette 41ee273
Switch nav2_smoother to modern CMake idioms.
clalancette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this added for AMCL specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is a good question. The honest truth is that for reasons I don't totally understand, having the targets in the subdirectory doesn't produce
nav2_amcl
targets that "worked". In particular, the downstream package linking against it (nav2_system_tests
) would fail to properly find the target. Moving this all together into the main CMakeLists.txt seemed to make it work. It bears more investigation into why that is happening.