Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BT nodes have configurable wait times (Backport #3960 #4178 #4203) #4409

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Make BT nodes have configurable wait times (Backport #3960 #4178 #4203) #4409

merged 4 commits into from
Jun 11, 2024

Commits on Jun 8, 2024

  1. WIP: Make BT nodes have configurable wait times. (ros-navigation#3960) 

    * Make BT nodes have configurable wait times.

Previous solution provided hardcoded 1s value.
Right now the value can be configured for BT
Action, Cancel and Service nodes.

[ros-navigation#3920]

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>

* Make BT nodes have configurable wait times.

Previous solution provided hardcoded 1s value.
Right now the value can be configured for BT
Action, Cancel and Service nodes.

[ros-navigation#3920]

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>

* Fix typos, linting errors and value type from float to int

* Fix extra underscores

* Fix extra underscore

* Update unit tests with blackboard parameter

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>

* Fix formatting errors

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>

* Update system tests to match new parameter

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>

---------

Signed-off-by: Adam Galecki <embeddedadam@gmail.com>
Signed-off-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
    @embeddedadam @christophfroehlich
    embeddedadam authored and christophfroehlich committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    2573f55 View commit details
    Browse the repository at this point in the history

  2. chore(nav2_behavior_tree): log actual wait period in bt_action_node (r… 

    …os-navigation#4178)

Signed-off-by: Felix <felix@fzeltner.de>
Co-authored-by: Felix <felix@fzeltner.de>
Signed-off-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
    @bi0ha2ard @christophfroehlich
    2 people authored and christophfroehlich committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    f72dee0 View commit details
    Browse the repository at this point in the history

  3. fix missing param declare (ros-navigation#4203) 

    Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
    @kaichie @christophfroehlich
    kaichie authored and christophfroehlich committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    5565efb View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Fix error messages (ros-navigation#4411) 

    Signed-off-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
    @christophfroehlich
    christophfroehlich committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    24c9c1e View commit details
    Browse the repository at this point in the history