Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dwb_critics to modern CMake idioms. #4611

Merged

Conversation

clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Update dwb_critics to use modern CMake idioms:

  1. Switch from ament_target_dependencies to target_link_libraries.
  2. Export a CMake target so downstream packages can use the libraries here.
  3. Push the include directories down one level, which is best practice since Humble.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger series updating Navigation2 to modern CMake idioms. There are approximately 6 packages left after this one. However, note that I will be taking a break from this work for one or two weeks, as I am on vacation, and still need to do the conversion for 4 more of the packages.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but rerunning CI. It failed on a test I've never seen fail before

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 5321e00 into ros-navigation:main Aug 9, 2024
11 checks passed
@clalancette clalancette deleted the clalancette/main-dwb-critics branch August 9, 2024 17:48
josephduchesne pushed a commit to josephduchesne/navigation2 that referenced this pull request Dec 10, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants