Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nav2_system_tests to modern CMake idioms. #4638

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Aug 21, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Update nav2_system_tests to use modern CMake idioms:

  1. Make everything in this package a test_depend, since this is all tests.
  2. Along with the previous point, move everything in this package under the BUILD_TESTING conditional in CMake.
  3. Switch from ament_target_dependencies to target_link_libraries everywhere.
  4. Remove all references to Boost.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger series updating Navigation2 to use modern CMake idioms. After this PR, there are 2 PRs left to open.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

I should also mention; with this in, my compile time savings locally is about 1 minute. This is substantially less than I originally saw in #4357; I suspect that there is some other bug on the iron branch that makes that one really slow. Regardless, I think we accomplished a lot with this series in terms of cleanup, so I'm happy we did it.

I'm also going to close #4357 at this point, as with this PR we accomplish everything that one set out to, and more.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@SteveMacenski SteveMacenski merged commit 8990c05 into ros-navigation:main Aug 22, 2024
11 checks passed
@SteveMacenski
Copy link
Member

I also noticed that the WPF wasn't updated https://github.com/ros-navigation/navigation2/blob/main/nav2_waypoint_follower/CMakeLists.txt - I don't think that's probably the difference maker in compile times, but would you mind doing the last one so they're all homogeneous?

@clalancette
Copy link
Contributor Author

I also noticed that the WPF wasn't updated https://github.com/ros-navigation/navigation2/blob/main/nav2_waypoint_follower/CMakeLists.txt - I don't think that's probably the difference maker in compile times, but would you mind doing the last one so they're all homogeneous?

Yeah, that's one of the last 2 PRs I have (the other is just some minor cleanup here and there). I left it to last because it also requires an update to robot_localization, which I haven't opened the PR for yet either. I'll do that soon.

@clalancette clalancette deleted the clalancette/main-nav2-system-tests branch August 22, 2024 17:29
josephduchesne pushed a commit to josephduchesne/navigation2 that referenced this pull request Dec 10, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants