Handle FindEigen3 module's differing definitions #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindEigen3.cmake
CMake module setsEIGEN3_INCLUDE_DIR
instead ofEIGEN3_INCLUDE_DIRS
. At the moment, Ubuntu only includes theEigen3Config.cmake
config, while Fedora includes both files. CMake appears to give precedence to the module over the config, so the config never gets processed.Alternatively, we could pass
NO_MODULE
to thefind_package
call, but this would fail on systems that ONLY have the module, though I'm not aware of any such distributions.A similar change was applied to rviz2.
In the current code, even when
Eigen3Config.cmake
is used andEIGEN3_INCLUDE_DIR
is referenced, a build warning comes out of catkin:This change should also resolve that warning.