Handle FindEigen3 module's differing definitions #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FindEigen3.cmake` CMake module sets `EIGEN3_INCLUDE_DIR` instead of `EIGEN3_INCLUDE_DIRS`. Ubuntu only includes the `Eigen3Config.cmake` config, while Fedora includes both files. CMake gives precedence to the module over the config, so the config never gets processed. Alternatively, we could pass `NO_MODULE` to the `find_package` call, but this would fail on systems that ONLY have the module, though I'm not aware of any such distributions.
cottsay
force-pushed
the
eigen3_module
branch
from
599bf0e to
a2107b8
Compare
cottsay
added
in review
sloretz
approved these changes
Jan 3, 2019
wjwwood
approved these changes
Jan 3, 2019
wjwwood
added a commit
that referenced
this pull request
Jan 15, 2019
* Revert "Migrate scalar displays (#367)" This reverts commit 9f3f3a6. * Revert "Handle FindEigen3 module's differing definitions (#370)" This reverts commit 2077b3a. * Revert "Skip the system directories when looking for OGRE (#371)" This reverts commit 61de77f. * Revert "Revert "Visibility followup for marker" (#369)" This reverts commit 712f903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindEigen3.cmakeCMake module setsEIGEN3_INCLUDE_DIRinstead ofEIGEN3_INCLUDE_DIRS. Ubuntu only includes theEigen3Config.cmakeconfig, while Fedora includes both files. CMake gives precedence to the module over the config, so the config never gets processed.Alternatively, we could pass
NO_MODULEto thefind_packagecall, but this would fail on systems that ONLY have the module, though I'm not aware of any such distributions.