-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gazebo_plugins: GPS sensor plugin publishing velocity #1371
Merged
jacobperron
merged 2 commits into
ros-simulation:foxy
from
MarcelDudek:gps-velocity-publisher
May 11, 2022
Merged
gazebo_plugins: GPS sensor plugin publishing velocity #1371
jacobperron
merged 2 commits into
ros-simulation:foxy
from
MarcelDudek:gps-velocity-publisher
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation.
Testing velocity messages provided by GPS plugin.
jacobperron
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the addition!
jacobperron
pushed a commit
that referenced
this pull request
May 11, 2022
* GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin.
jacobperron
pushed a commit
that referenced
this pull request
May 11, 2022
* GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin.
jacobperron
added a commit
that referenced
this pull request
May 11, 2022
* GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin. Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com>
jacobperron
added a commit
that referenced
this pull request
May 11, 2022
* GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin. Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com>
afonsofonbraga
pushed a commit
to afonsofonbraga/gazebo_ros_pkgs
that referenced
this pull request
Aug 4, 2022
…#1371) (ros-simulation#1386) * GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin. Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com>
GB255
pushed a commit
to brisa-robotics/gazebo_ros_pkgs
that referenced
this pull request
Aug 5, 2022
* fix: limits of steering speed control * gazebo_plugins: GPS sensor plugin publishing velocity (ros-simulation#1371) (ros-simulation#1386) * GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin. Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com> * gazebo_ros: Add inline keyword to template definitions (ros-simulation#1367) * gazebo_ros: Add inline keyword to template definitions * Uncrustify Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Gerard Heshusius <gHeshusius@lely.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> * Use shell=False in when launching gazebo (ros-simulation#1384) Signed-off-by: Aditya <aditya050995@gmail.com> * Fix sim time test (ros-simulation#1390) Partial backport of ros-simulation#1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com> Co-authored-by: Gerard Heshusius <gh.heshusius@gmail.com> Co-authored-by: Gerard Heshusius <gHeshusius@lely.com> Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods
that allow for velocity simulation. Based on previous commits this was not implemented in Gazebo 9.0 and therefore velocity support was not implemented for GPS plugin.
Added publisher for velocity data simulated by sensor. It outputs data as
geometry_msgs::mgs::Vector3Stamped
.NavFix
unfortunately doesn't support velocity data and there is no suitable message insensors_msgs
.Velocity data is in ENU coordinates.