[gazebo_plugins] Rapid projector toggle rostest #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can reproduce crashing of gazebo
…row strip of texture missing that is projected in a different direction):
~/catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/test/projector$ GAZEBO_RESOURCE_PATH=`pwd` roslaunch gazebo_plugins projector.test gui:=true
Trying to turn off the projector doesn't work, though this has worked for me from xacro/urdf (TODO make a xacro example to show that):
rostopic pub /projector_plugin/projector std_msgs/Int32 "data: 0"
Need to test the texture topic.
…gle works. Haven't gotten a crash from rapid toggling on a single projector, should try two. The xacro is incomplete.
lucasw
changed the title
| test/set_model_state_test/set_model_state_test.test | ||
| test/set_model_state_test/set_model_state_test.cpp) | ||
| target_link_libraries(set_model_state-test ${catkin_LIBRARIES}) | ||
| # Can't have two of these until #409 is resolved |
There was a problem hiding this comment.
I think that we are safe to enable all the tests again, #409 was closed by running tests one by one.
|
Thanks for the contribution Lucas. Could you please fix the conflicts when you have some time? |
|
No activity since 2016 and targeting an unsupported version. Closing this feel free to reopen again in a supported version if the PR is relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally was hoping to duplicate an issue where toggling a projector on and off would crash gazebo, but having made a rostest of it the test passes. But I think it is a good test and could be developed into more elaborate tests of projectors (adding a camera and some image comparison tests to see that the projector actually projected and toggled on and off would be nice), and serves as an example of launching the projector plugin in a world file (I couldn't find a recent one).
The xacro file will be built into a similar test that uses the xacro -> urdf -> sdf pipeline, it could be left out of the merge until I finish it, or I could finish it first.