Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gazebo_plugins] Publish camera info properly for depth cameras. #570

Closed
wants to merge 1 commit into from
Closed

Conversation

ksatyaki
Copy link

Aims to address #569

@ksatyaki ksatyaki changed the title Publish camera info properly for depth cameras. [gazebo_plugins] Publish camera info properly for depth cameras. Aug 27, 2017
@ksatyaki ksatyaki closed this Aug 27, 2017
@ksatyaki ksatyaki reopened this Aug 27, 2017
@ksatyaki
Copy link
Author

ksatyaki commented Mar 8, 2018

Has this been addressed already? Any info?

@j-rivero
Copy link
Contributor

j-rivero commented Mar 8, 2018

Has this been addressed already? Any info?

I don't think so. Some comments after giving a quick look into the PR:

  • You are removing some protected functions so we are altering the API in the PR. Since kinetic is a mature release I'm not in favour of ABI changes to it. If you are interested into getting the changes in kinetic we should come up with changes that respect the ABI. API changes can go into the next Melodic release.
  • I would like to include a test or at least an example that somehow can be run to demonstrate that we are not breaking camera support and that helps to verify that the new information is indeed being published.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants