Publish camera info in gazebo_ros_depth_camera plugin #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw that this has been approved for a long time but never merged. Merging! |
|
Ah thanks @chapulina . I've forgotten about it and hence didn't bump it. BTW #569 and #570 seem to be related to this and might need attention too. |
|
Hi, I'm on noetic and camera info is not being published for depth. Looking at the code it looks like this has been merged in kinetic, but not in melodic-devel and noetic-devel. |
|
@c-rizz Apparently @kev-the-dev 's refactoring should fix it. But it doesn't seem to be merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublishCameraInfo()function was created but it wasn't used. I needed camera info to be published. It might be useful for other people too.Thanks for review.