-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Get multiline action input - parse as JSON #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
- Coverage 42.42% 40.19% -2.23%
==========================================
Files 2 2
Lines 198 204 +6
Branches 36 36
==========================================
- Hits 84 82 -2
- Misses 114 122 +8
Continue to review full report at Codecov.
|
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
changed the title
Try getting yaml contents from action argument
[test] Get multiline action input - parse as JSON
Mar 2, 2021
emersonknapp
pushed a commit
that referenced
this pull request
Mar 10, 2021
@emersonknapp this can be closed now that #570 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
This is a test to try enabling generic solution for #526
|
pipe to start multiline string, we can havecore.getInput
return a long string.$COLCON_HOME/defaults.yaml
as per add colcon-mixin-name-build and colcon-mixin-name-test overrides #526. We could also write it anywhere and point to it viaCOLCON_DEFAULTS_FILE
environment variable. Any JSON we expect here will be valid YAML as well.