Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionally support Qt5 #359

Merged
merged 15 commits into from
Apr 27, 2016
Merged

additionally support Qt5 #359

merged 15 commits into from
Apr 27, 2016

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Mar 30, 2016

With these patches the same code base can satisfy both of the following use cases (with only minimal try / except logic:

The version dependency on python_qt_binding ensures that the packages which use QtWidgets are getting the changes from ros-visualization/python_qt_binding#31.

This is required for a release into Kinetic.

@dirk-thomas
Copy link
Contributor Author

As a follow up of this PR the package rqt_plot will be moved into a separate repository since it requires a Qt version specific dependency on Qwt. Since I don't want to branch this repo for Kinetic rqt_plot is extracted since it requires branching.

@trainman419
Copy link
Contributor

rqt_bag depends on rqt_plot, so that may need to move as well.

@dirk-thomas
Copy link
Contributor Author

rqt_bag doesn't need to move. Only rqt_plot needs a different dependency in its manifest. rqt_bag can continue to use it even if it is in a different repo.

@trainman419
Copy link
Contributor

The dependency chain now is rqt_bag_plugins -> rqt_plot -> rqt_py_common. Moving the middle item in that dependency chain out of the repository seems like it will cause confusion for people building from source, and I'm not convinced that tools like bloom or devel jobs are designed for that situation.

@dirk-thomas
Copy link
Contributor Author

That is true. A circular dependency on the repository level is not fun and should be avoided. I might create a "relay" package then which just chooses the Qwt version. Then that package can be branches and rqt_plot and friends can stay in this repo (without a need to branch).

@dirk-thomas
Copy link
Contributor Author

I created a "dependency only" package called qwt_dependency which lives outside of this repo and is now being used as a dependency: 3ac086c

That way we can use Qwt 5 for Jade and older and Qwt 6.1 for Kinetic (once it becomes available as a system package or someone creates a custom package which we import into our apt repo).

@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Apr 20, 2016

With PySide 2 there are no working backends for plotting at the moment. There are either no packages available upstream or the package is too old (in the case of matplotlib it supports PySide 2 only as of the upcoming release 2.1). We would need to create our own package of one of the backend libraries to support it in Kinetic.

@dirk-thomas
Copy link
Contributor Author

I posted on the SIG and am looking forward for feedback on these changes: https://groups.google.com/forum/#!topic/ros-sig-rqt/1zcA4xlQ3E0

@dirk-thomas dirk-thomas merged commit 1226f14 into master Apr 27, 2016
@dirk-thomas dirk-thomas deleted the qt5 branch April 27, 2016 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants