Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI for Noetic #1505

Merged
merged 3 commits into from
May 18, 2020

Conversation

rhaschke
Copy link
Contributor

This PR comprises several minor fixes to get Travis CI passing again. Some of them are preliminary workarounds for open issues:

rhaschke added 2 commits May 13, 2020 16:23
* build on Noetic image
* use private moveit_ci (working around some python3 + catkin tools issues)
* use private python_qt_binding (silencing build warnings)
* re-enable ABI test
* enable Ogre 1.12 build
Adapt .clang-format config for clang-format-10.
@rhaschke rhaschke changed the base branch from melodic-devel to noetic-devel May 13, 2020 14:34
-Wdeprecated-copy
-Wclass-memaccess
-Woverloaded-virtual
@rhaschke
Copy link
Contributor Author

Closing and reopening to retrigger CI.

@rhaschke rhaschke closed this May 14, 2020
@rhaschke rhaschke reopened this May 14, 2020
@rhaschke
Copy link
Contributor Author

@wjwwood, @sloretz: Do you have an idea why the ROS build farm reports a failure here?
The build job actually succeeds - we just have a few cmake and compiler warnings - but all of them are triggered by external sources.

I already filed an issue for the assimp cmake warning: assimp/assimp#3166
All the compiler issues are related to a new gcc/clang warning (-Wdeprecated-copy), which is triggered in the sip build, as this activates all warnings (-Wall) from Qt's cflags.
To suppress them, we would need a way to pass extra cflags to python_qt_bindings.
For the Travis, I use the following quick fix to do so: rhaschke/python_qt_binding@4eedad5
From my point of view, the correct solution to this issue is to declare all external includes as -isystem.

@wjwwood
Copy link
Member

wjwwood commented May 14, 2020

@wjwwood, @sloretz: Do you have an idea why the ROS build farm reports a failure here?
The build job actually succeeds - we just have a few cmake and compiler warnings - but all of them are triggered by external sources.

I don't think the Jenkins plugin that reports this stuff to GitHub distinguishes between unstable and failure, but I'm not 100% sure.

I already filed an issue for the assimp cmake warning: assimp/assimp#3166

FYI https://bugs.launchpad.net/ubuntu/+source/assimp/+bug/1869405 and ros2/rviz#524 and ros2/rviz#534

From my point of view, the correct solution to this issue is to declare all external includes as -isystem.

I would caution against this, as we've run into subtle issues in the past with include orders being messed up when using -isystem. I'd prefer to fix warnings where they are or use the pragma diagnostics to suppress warnings where we include them if possible. Patching python_qt_bindings also seems appropriate.

@rhaschke rhaschke merged commit 25f377d into ros-visualization:noetic-devel May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants