Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgbd_launch: 2.3.0-1 in 'noetic/distribution.yaml' [semi-bloom] #25278

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

130s
Copy link
Member

@130s 130s commented Jun 3, 2020

Increasing version of package(s) in repository rgbd_launch to 2.3.0:

Increasing version of package(s) in repository `rgbd_launch` to `2.3.0`:

- upstream repository: https://github.com/ros-drivers/rgbd_launch.git
- release repository: https://github.com/ros-gbp/rgbd_launch-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
@130s 130s changed the title [noetic] rgbd_launch 2.3.0 rgbd_launch: 2.3.0-1 in 'noetic/distribution.yaml' [semi-bloom] Jun 3, 2020
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@130s while reviewing I noticed a bug ros-drivers/rgbd_launch#50 . Would you rather release this now, or fix the bug and create a new release?

@130s
Copy link
Member Author

130s commented Jun 3, 2020

@sloretz Thank you for the catch. Since this release unblocks downstream pkgs, I'd like this to be merged sooner. Then I can make a subsequent release.

@sloretz sloretz merged commit fe2d960 into ros:master Jun 3, 2020
@130s 130s deleted the rlease-noetic-rgbd-launch branch June 3, 2020 19:31
sloretz pushed a commit that referenced this pull request Aug 5, 2020
Increasing version of package(s) in repository `rgbd_launch` to `2.3.0`:

- upstream repository: https://github.com/ros-drivers/rgbd_launch.git
- release repository: https://github.com/ros-gbp/rgbd_launch-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants