[rosdep] add python3 keys for pymodbus and urllib3 #26056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debian: https://packages.debian.org/buster/python3-pymodbus fedora: https://fedora.pkgs.org/32/fedora-x86_64/python3-pymodbus-2.3.0-2.fc32.noarch.rpm.html ubuntu: https://packages.ubuntu.com/focal/python3-pymodbus Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
debian: https://packages.debian.org/buster/python3-urllib3 fedora: https://fedora.pkgs.org/32/fedora-x86_64/python3-urllib3-1.25.7-3.fc32.noarch.rpm.html gentoo: https://packages.gentoo.org/packages/dev-python/urllib3 ubuntu: https://packages.ubuntu.com/focal/python3-urllib3 Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
sloretz
approved these changes
Aug 10, 2020
clalancette
requested changes
Aug 11, 2020
rosdep/python.yaml
Outdated
| @@ -5998,6 +5998,10 @@ python3-pykdl: | |||
| '*': [python3-pykdl] | |||
| 'bionic': null | |||
| 'xenial': null | |||
| python3-pymodbus: | |||
| debian: [python3-pymodbus] | |||
There was a problem hiding this comment.
This key isn't available in stretch. It is available in stretch-backports, but we don't usually allow keys in the backports repository, as I understand it. So I think this will have to get split out to a null key for stretch and python3-pymodbus for everything else.
There was a problem hiding this comment.
I didnt know stretch was still a required platform for new keys as it went EOL last month.
Addressed in 85aee79
There was a problem hiding this comment.
I didnt know stretch was still a required platform for new keys as it went EOL last month.
I didn't realize that. Thanks for the heads up; for now, I think we can leave the key since we've added it.
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
clalancette
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymodbus:
debian: https://packages.debian.org/buster/python3-pymodbus
fedora: https://fedora.pkgs.org/32/fedora-x86_64/python3-pymodbus-2.3.0-2.fc32.noarch.rpm.html
ubuntu: https://packages.ubuntu.com/focal/python3-pymodbus
urllib3:
debian: https://packages.debian.org/buster/python3-urllib3
fedora: https://fedora.pkgs.org/32/fedora-x86_64/python3-urllib3-1.25.7-3.fc32.noarch.rpm.html
gentoo: https://packages.gentoo.org/packages/dev-python/urllib3
ubuntu: https://packages.ubuntu.com/focal/python3-urllib3